Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return user-set maximum topography when the initial topography model Function is asked for the max topography #5506

Merged
merged 4 commits into from
Jan 25, 2024

Conversation

anne-glerum
Copy link
Contributor

@anne-glerum anne-glerum commented Nov 28, 2023

The maximum topography is read in from the prm for the function initial topography model, but it is not used. This PR returns the user-set maximum topography when the topography model is asked for it. It is not used to restrict topography as given by the function itself, and the user should take care that the value is reasonable.

For all pull requests:

For new features/models or changes of existing features:

  • I have tested my new feature locally to ensure it is correct.
  • I have created a testcase for the new feature/benchmark in the tests/ directory.
  • I have added a changelog entry in the doc/modules/changes directory that will inform other users of my change.

@anne-glerum
Copy link
Contributor Author

The four failing tests are all tests that include initial topography through the function plugin.

Copy link
Member

@gassmoeller gassmoeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this was clearly an oversight. Can you update the test output? Afterwards this is good to go.

@anne-glerum
Copy link
Contributor Author

@gassmoeller I've updated the test results. The failing tests on dealii-master are still all gmg tests with the same error.

Copy link
Member

@gassmoeller gassmoeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, good to go.

@gassmoeller gassmoeller merged commit e8da178 into geodynamics:main Jan 25, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants