Make sure stuff in compat.h/cc is guarded by a deal.II version. #5503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I meant to add that I waited with this patch, rather than include it in the original PR, because we needed to wait for the deal.II images used in our CI check to cycle. |
tjhei
approved these changes
Nov 28, 2023
|
The one failure is the |
gassmoeller
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5474 added a copy of
SphericalManifoldto ASPECT because of the broken interface in deal.II releases. This patch adds#ifguards on the deal.II version to make sure we know when we can remove these things again.Related to #5421.