Ensure correct solver scheme for PDA #5465
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The entropy material model requires iterating over advection and Stokes equations (because temperature diffusion is computed split from entropy advection). This was not asserted so far and has let to problems with temperature overshoot in other solver schemes. Also assert that the projected density mass conservation formulation always uses a compressible material model.
@jdannberg, @RanpengLi does this make sense?