Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure correct solver scheme for PDA #5465

Merged

Conversation

gassmoeller
Copy link
Member

The entropy material model requires iterating over advection and Stokes equations (because temperature diffusion is computed split from entropy advection). This was not asserted so far and has let to problems with temperature overshoot in other solver schemes. Also assert that the projected density mass conservation formulation always uses a compressible material model.

@jdannberg, @RanpengLi does this make sense?

@jdannberg
Copy link
Contributor

Conceptually, this makes sense to me, but sometimes we want to run a model and just check the initial conditions and therefore select the no Advection, no Stokes solver scheme, which technically is not consistent with any material model. For example, one might want to write a test that just checks the conversion from temperature to entropy and back. Or, someone might have a prescribed Stokes solution but still wants to solve the temperature equation using entropy.

Therefore, it would be good to either have an input parameter that does this check by default, but can be disabled ("Check solver scheme consistency" or something like that) or at least allow the no Advection, no Stokes option as well.

@gassmoeller
Copy link
Member Author

Good point. What do you think about the current version? The only solver schemes that are not allowed are the ones that only solve advection equations once and move forward in time.

@jdannberg
Copy link
Contributor

Yes, I think that makes sense!
This also leaves the option open to just set the number of Nonlinear iterations to 1 in an iterative scheme if someone really, really thinks that this is what they want.

@gassmoeller gassmoeller merged commit b5933c0 into geodynamics:main Nov 3, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants