Custom binIDs [WIP: Needs some frontend work still] #115
Conversation
|
+1 to leaving it where it deletes data after 48 hours. This is not supposed to be a place to store data. |
|
Custom bin IDs don't show up in the history currently. Making a note here so that I'll remember to fix that before marking this PR ready to merge. |
| @@ -13,6 +13,28 @@ import ( | |||
| "github.com/nu7hatch/gouuid" | |||
| ) | |||
|
|
|||
| func (gb *geobinServer) createBin(n string, w http.ResponseWriter) (time.Time, error) { | |||
There was a problem hiding this comment.
This function needs a doc comment!
…nstead of an invalid one
aranasaurus
force-pushed
the
custom-binids
branch
from
17fc004 to
3245b86
Compare
…r the data visibility, expiration, and custom bin ids stuff.
|
@aranasaurus is this good to merge? |
|
well it would be merged into the Dev branch so we could at least continue development on it from here rather than just your fork |
|
ok. I could also just push it to a branch upstream that's not dev. I think it was far enough along to not break everything though... so it's probably fine to merge to dev. CI says it's good, I guess. In other words, either way. Merge it if you want, or just close the PR and I'll push the branch. |
|
@aranasaurus If you've got time to push it to a feature branch on upstream that works for me. I just want to help get it done and live. Talked with Court and Josh a bit about potentially decoupling web app from api (e.g. geobin.io & api.geobio.io repos) so we can develop them in parallel and not mix streams too much. |
|
That sounds great. I hope to get some more time to put toward geobin again, hopefully next month... Anyway, feature branch created! |
|
@aranasaurus Cool, I will close this PR and futz with your feature branch on my fork. Thanks! |
|
@aranasaurus going to rebase |
Changes to support custom bin IDs for #82. Also makes changes that effectively implement the activity refreshing the expiration (#101) as any request to a bin that doesn't exist will create said bin instead of 404ing. We'll need to talk more about whether or not the data should actually persist more than 48 hours based on activity.