Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PB-1318 : delete KML definitively #1224

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

sami-nouidri-swisstopo
Copy link
Contributor

@sami-nouidri-swisstopo sami-nouidri-swisstopo commented Jan 28, 2025

KML deletion is now done by sending a request to the pre-existing DELETE route in the service-kml backend.

Test link

Copy link

cypress bot commented Jan 28, 2025

web-mapviewer    Run #4405

Run Properties:  status check passed Passed #4405  •  git commit 882de5f3cb: PB-1318 : fixed imports
Project web-mapviewer
Branch Review task-PB-1318-delete-kml
Run status status check passed Passed #4405
Run duration 05m 55s
Commit git commit 882de5f3cb: PB-1318 : fixed imports
Committer Sami Nouidri
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 21
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 233
View all changes introduced in this branch ↗︎

Sami Nouidri added 4 commits January 30, 2025 14:15
The functions 'deleteDrawing()' and 'deleteKml' have been added to fully delete
the kml, using the existing DELETE route. A back-end URL override has been added
for service-kml as well, although it doesn't seem to work for now.
@sami-nouidri-swisstopo sami-nouidri-swisstopo marked this pull request as ready for review January 30, 2025 13:18
@sami-nouidri-swisstopo sami-nouidri-swisstopo changed the title PB-1318 : started work on routines to delete KML using service-kml PB-1318 : delete KML definitively Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant