PB-1406: Make cognito authenticated users superuser #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Might be a bit early, let's discuss this next week... |
|
Will create a new PR when decided and needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
RemoteUserBackendcreates an authenticated user if it not already exists (create_unknown_useris set by default). I suggest we generally set the superuser flag for the cognito authenticated users until we implement proper authorization. The other possibility would be to setcreate_unknown_userand create the users by hand (auth-attempts for non-existing users will then return 401 instead of 403).I also updated the tests for v1 to use the new authentication method, as this is what we want to use there so it doesn't make much sense to use another authentication method in the test.
What do you think?