Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not login when testing search endpoint #507

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Conversation

msom
Copy link
Contributor

@msom msom commented Jan 28, 2025

Unit tests should not do a login for the search endpoint since it's public.

@msom msom requested a review from adk-swisstopo January 28, 2025 08:30
Copy link
Member

@adk-swisstopo adk-swisstopo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Can you do the same for v0.9 please? :)

@msom
Copy link
Contributor Author

msom commented Jan 28, 2025

Looks good. Can you do the same for v0.9 please? :)

Sure, totally missed that.

@adk-swisstopo
Copy link
Member

Looks good. Can you do the same for v0.9 please? :)

Sure, totally missed that.

The vagaries of copy/paste :)

@msom msom force-pushed the remove-login-in-search-test branch from ec054bf to e713a37 Compare January 28, 2025 08:37
@msom msom merged commit 68eb9df into develop Jan 28, 2025
3 checks passed
@msom msom deleted the remove-login-in-search-test branch January 28, 2025 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants