Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

using GET range request instead of HEAD to check external asset reach… #499

Merged
merged 2 commits into from
Jan 23, 2025
Merged

using GET range request instead of HEAD to check external asset reach… #499

merged 2 commits into from
Jan 23, 2025

Conversation

boecklic
Copy link
Contributor

…ability

@benschs
Copy link
Contributor

benschs commented Jan 23, 2025

@boecklic Added check for content length.
Added unit tests using the responses lib to mock the external asset url response.

boecklic and others added 2 commits January 23, 2025 15:02
@boecklic @benschs
using GET range request instead of HEAD to check external asset reach…
7876b73 
…ability
@benschs
PB-1372: Check content length of external asset
7f44864 
Add content length check when validating external asset url.
Add test cases.
@benschs benschs force-pushed the feat_PB-1372_range_request_external_asset_href branch from 488bad4 to 7f44864 Compare January 23, 2025 14:03
@benschs benschs self-requested a review January 23, 2025 14:03
@boecklic boecklic merged commit 89c4804 into develop Jan 23, 2025
3 checks passed
@boecklic boecklic deleted the feat_PB-1372_range_request_external_asset_href branch January 23, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benschs benschs benschs approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@boecklic @benschs