Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-python/{cligj,fiona,geopandas}: version bumps & improvements #1302

Closed
wants to merge 8 commits into from

Conversation

fkobi
Copy link
Contributor

@fkobi fkobi commented Nov 15, 2024

I needed them for my studies so I have decided to work a bit more for the community

dev-python/fiona/fiona-1.10.1.ebuild Outdated Show resolved Hide resolved
dev-python/fiona/fiona-1.10.1.ebuild Outdated Show resolved Hide resolved
- introduce DISTUTILS_EXT
- use EPYTEST_DESELECT
- tests
  - add test? BDEPENDs
  - reintroduce one test
  - mask one test
  - remove commented out code
  - improve wording of first deselected tests comment

Signed-off-by: Filip Kobierski <[email protected]>
Signed-off-by: Filip Kobierski <[email protected]>
distutils_enable_tests pytest

python_test() {
local deselect=(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here too you can use EPYTEST_DESELECT instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.
However I think that EPYEST_IGNORE does not work...
Could you check that please?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EPYTEST_IGNORE takes files, not individual tests like EPYTEST_DESELECT.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And tests with a [..] need to be quoted, otherwise the deselecting is ineffective.

@fkobi fkobi force-pushed the master branch 2 times, most recently from c7e7af6 to 77c6265 Compare November 16, 2024 20:32
Comment on lines 34 to 39
geopandas/tests/test_plotting.py::TestGeoplotAccessor::test_pandas_kind
)
EPYTEST_IGNORE=(
# rtree results are known to be unordered
geopandas/tests/test_sindex.py::TestShapelyInterface::test_query_bulk_sorting[False-expected1]
geopandas/tests/test_sindex.py::TestShapelyInterface::test_query_sorting[False-expected1]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
geopandas/tests/test_plotting.py::TestGeoplotAccessor::test_pandas_kind
)
EPYTEST_IGNORE=(
# rtree results are known to be unordered
geopandas/tests/test_sindex.py::TestShapelyInterface::test_query_bulk_sorting[False-expected1]
geopandas/tests/test_sindex.py::TestShapelyInterface::test_query_sorting[False-expected1]
geopandas/tests/test_plotting.py::TestGeoplotAccessor::test_pandas_kind
# rtree results are known to be unordered
'geopandas/tests/test_sindex.py::TestShapelyInterface::test_query_bulk_sorting[False-expected1]'
'geopandas/tests/test_sindex.py::TestShapelyInterface::test_query_sorting[False-expected1]'

- add version numbers to DEPENDs
- use EPYTEST_DESELECT
- add known test failiures to deselect
- improve comment
- clean out optfeatures

Signed-off-by: Filip Kobierski <[email protected]>
@Nowa-Ammerlaan
Copy link
Member

Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants