Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sci-libs/cuba: new package, add 4.2.2 #1291

Closed
wants to merge 7 commits into from

Conversation

APN-Pucky
Copy link
Contributor

PR created by pkgpr.

Please check all the boxes that apply:

  • I can submit this contribution in agreement with the Copyright Policy.
  • I have certified the above via adding a Signed-off-by line to every commit in the pull request.
  • This contribution has not been created with the assistance of Natural Language Processing artificial intelligence tools, in accordance with the AI policy.
  • I have run pkgcheck scan --commits --net to check for issues with my commits.

Please note that all boxes must be checked for the pull request to be merged.

Signed-off-by: Alexander Puck Neuwirth <[email protected]>
Copy link
Member

@Nowa-Ammerlaan Nowa-Ammerlaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some stylistic comments, and a missing || die.

sci-libs/cuba/cuba-4.2.2.ebuild Outdated Show resolved Hide resolved
sci-libs/cuba/cuba-4.2.2.ebuild Outdated Show resolved Hide resolved
sci-libs/cuba/cuba-4.2.2.ebuild Outdated Show resolved Hide resolved
sci-libs/cuba/cuba-4.2.2.ebuild Outdated Show resolved Hide resolved
sci-libs/cuba/metadata.xml Outdated Show resolved Hide resolved
sci-libs/cuba/cuba-4.2.2.ebuild Outdated Show resolved Hide resolved
Signed-off-by: Alexander Puck Neuwirth <[email protected]>
@APN-Pucky
Copy link
Contributor Author

Thanks, I must admit I did not closely inspect before. I just wanted to check if my added --check-boxes to pkgpr works with github. I should have used the also new --draft option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants