chore: Disable no-empty-object eslint rule. (#206)

## Proposed changes Disable the no-empty-object eslint rule so we can do things like `gsx.Component<{}, string>`
gensx-inc · Jan 29, 2025 · 203b557 · 203b557
1 parent c611e61
commit 203b557
Show file tree

Hide file tree

Showing 16 changed files with 46 additions and 101 deletions.
diff --git a/docs/src/content/docs/basic-concepts.mdx b/docs/src/content/docs/basic-concepts.mdx
@@ -166,7 +166,7 @@ interface User {
 const UserContext = gsx.createContext({ name: "" });
 
 // Use the context in a component
-const Greeting = gsx.Component<Record<never, never>, string>("Greeting", () => {
+const Greeting = gsx.Component<{}, string>("Greeting", () => {
   const user = gsx.useContext(UserContext);
   return `Hello, ${user.name}!`;
 });

diff --git a/docs/src/content/docs/concepts/context.mdx b/docs/src/content/docs/concepts/context.mdx
@@ -49,13 +49,10 @@ const UserContext = gsx.createContext<User>({
 To use the context, call the `gsx.useContext(context)` hook inside of a component. Here a `Greeting` component is created that uses the `UserContext` to get the user's name:
 
 ```tsx
-const Greeting = gsx.Component<Record<never, never>, GreetingOutput>(
-  "Greeting",
-  () => {
-    const user = gsx.useContext(UserContext);
-    return `Hello, ${user.name}!`;
-  },
-);
+const Greeting = gsx.Component<{}, GreetingOutput>("Greeting", () => {
+  const user = gsx.useContext(UserContext);
+  return `Hello, ${user.name}!`;
+});
 ```
 
 ### Step 3: Provide the context value

diff --git a/docs/src/env.d.ts b/docs/src/env.d.ts
@@ -1,8 +1,7 @@
 /// <reference types="astro/client" />
 
 // This interface is used to augment the ImportMetaEnv type
-// eslint-disable-next-line @typescript-eslint/no-empty-object-type
-interface ImportMetaEnv extends Record<string, unknown> {
+interface ImportMetaEnv extends {} {
   // Add environment variables here
 }
 

diff --git a/docs/worker-configuration.d.ts b/docs/worker-configuration.d.ts
@@ -1,7 +1,6 @@
 // Generated by Wrangler
 // After adding bindings to `wrangler.toml`, regenerate this interface via `npm run cf-typegen`
 // This interface is used to define the environment variables for Cloudflare Workers
-// eslint-disable-next-line @typescript-eslint/no-empty-object-type
-interface Env extends Record<string, unknown> {
+interface Env extends {} {
   // Add environment variables here
 }
diff --git a/eslint.config.mjs b/eslint.config.mjs
@@ -107,16 +107,7 @@ export default [
           ],
         },
       ],
-    },
-  },
-  {
-    files: ["examples/**"],
-    rules: {
-      "no-console": "off",
-      "@typescript-eslint/no-unsafe-assignment": "off",
-      "@typescript-eslint/no-unsafe-member-access": "off",
-      "@typescript-eslint/no-unsafe-call": "off",
-      "@typescript-eslint/no-unsafe-return": "off",
+      "@typescript-eslint/no-empty-object-type": "off",
     },
   },
   {
@@ -130,6 +121,7 @@ export default [
       "vitest/no-disabled-tests": "warn",
       "vitest/expect-expect": "off",
       "vitest/no-standalone-expect": "off",
+      "@typescript-eslint/no-empty-object-type": "off",
     },
   },
 ];
diff --git a/examples/blogWriter/eslint.config.mjs b/examples/blogWriter/eslint.config.mjs
@@ -1,7 +1,9 @@
 import rootConfig from "../../eslint.config.mjs";
+import examplesConfig from "../eslint.config.mjs";
 
 export default [
   ...rootConfig,
+  ...examplesConfig,
   {
     files: ["**/*.{js,mjs,cjs,jsx,ts,tsx}"],
     languageOptions: {
@@ -10,13 +12,5 @@ export default [
         project: "./tsconfig.json",
       },
     },
-    rules: {
-      "@typescript-eslint/no-unsafe-assignment": "off",
-      "@typescript-eslint/no-unsafe-call": "off",
-      "@typescript-eslint/no-unsafe-member-access": "off",
-      "@typescript-eslint/no-unsafe-return": "off",
-      "@typescript-eslint/no-unsafe-argument": "off",
-      "node/no-unsupported-features/es-syntax": "off",
-    },
   },
 ];
diff --git a/examples/contexts/eslint.config.mjs b/examples/contexts/eslint.config.mjs
@@ -1,7 +1,9 @@
 import rootConfig from "../../eslint.config.mjs";
+import examplesConfig from "../eslint.config.mjs";
 
 export default [
   ...rootConfig,
+  ...examplesConfig,
   {
     files: ["**/*.{js,mjs,cjs,jsx,ts,tsx}"],
     languageOptions: {
@@ -10,13 +12,5 @@ export default [
         project: "./tsconfig.json",
       },
     },
-    rules: {
-      "@typescript-eslint/no-unsafe-assignment": "off",
-      "@typescript-eslint/no-unsafe-call": "off",
-      "@typescript-eslint/no-unsafe-member-access": "off",
-      "@typescript-eslint/no-unsafe-return": "off",
-      "@typescript-eslint/no-unsafe-argument": "off",
-      "node/no-unsupported-features/es-syntax": "off",
-    },
   },
 ];
diff --git a/examples/contexts/index.tsx b/examples/contexts/index.tsx
@@ -12,13 +12,10 @@ const UserContext = gsx.createContext<User>({
 type GreetingOutput = string;
 
 // Use the context in a component
-const Greeting = gsx.Component<Record<never, never>, GreetingOutput>(
-  "Greeting",
-  () => {
-    const user = gsx.useContext(UserContext);
-    return `Hello, ${user.name}!`;
-  },
-);
+const Greeting = gsx.Component<{}, GreetingOutput>("Greeting", () => {
+  const user = gsx.useContext(UserContext);
+  return `Hello, ${user.name}!`;
+});
 
 async function main() {
   // Provide a value to the context

diff --git a/examples/deepResearch/eslint.config.mjs b/examples/deepResearch/eslint.config.mjs
@@ -1,7 +1,9 @@
 import rootConfig from "../../eslint.config.mjs";
+import examplesConfig from "../eslint.config.mjs";
 
 export default [
   ...rootConfig,
+  ...examplesConfig,
   {
     files: ["**/*.{js,mjs,cjs,jsx,ts,tsx}"],
     languageOptions: {
@@ -10,13 +12,5 @@ export default [
         project: "./tsconfig.json",
       },
     },
-    rules: {
-      "@typescript-eslint/no-unsafe-assignment": "off",
-      "@typescript-eslint/no-unsafe-call": "off",
-      "@typescript-eslint/no-unsafe-member-access": "off",
-      "@typescript-eslint/no-unsafe-return": "off",
-      "@typescript-eslint/no-unsafe-argument": "off",
-      "node/no-unsupported-features/es-syntax": "off",
-    },
   },
 ];
diff --git a/examples/eslint.config.mjs b/examples/eslint.config.mjs
@@ -0,0 +1,15 @@
+export default [
+  {
+    files: ["**/*.ts", "**/*.tsx"],
+    rules: {
+      "@typescript-eslint/no-empty-object-type": "off",
+      "@typescript-eslint/no-unsafe-argument": "off",
+      "@typescript-eslint/no-unsafe-assignment": "off",
+      "@typescript-eslint/no-unsafe-call": "off",
+      "@typescript-eslint/no-unsafe-member-access": "off",
+      "@typescript-eslint/no-unsafe-return": "off",
+      "no-console": "off",
+      "node/no-unsupported-features/es-syntax": "off",
+    },
+  },
+];
diff --git a/examples/groq-deepseek-r1-distilled/eslint.config.mjs b/examples/groq-deepseek-r1-distilled/eslint.config.mjs
@@ -1,7 +1,9 @@
 import rootConfig from "../../eslint.config.mjs";
+import examplesConfig from "../eslint.config.mjs";
 
 export default [
   ...rootConfig,
+  ...examplesConfig,
   {
     files: ["**/*.{js,mjs,cjs,jsx,ts,tsx}"],
     languageOptions: {
@@ -10,13 +12,5 @@ export default [
         project: "./tsconfig.json",
       },
     },
-    rules: {
-      "@typescript-eslint/no-unsafe-assignment": "off",
-      "@typescript-eslint/no-unsafe-call": "off",
-      "@typescript-eslint/no-unsafe-member-access": "off",
-      "@typescript-eslint/no-unsafe-return": "off",
-      "@typescript-eslint/no-unsafe-argument": "off",
-      "node/no-unsupported-features/es-syntax": "off",
-    },
   },
 ];
diff --git a/examples/hackerNewsAnalyzer/eslint.config.mjs b/examples/hackerNewsAnalyzer/eslint.config.mjs
@@ -1,7 +1,9 @@
 import rootConfig from "../../eslint.config.mjs";
+import examplesConfig from "../eslint.config.mjs";
 
 export default [
   ...rootConfig,
+  ...examplesConfig,
   {
     files: ["**/*.{js,mjs,cjs,jsx,ts,tsx}"],
     languageOptions: {
@@ -10,13 +12,5 @@ export default [
         project: "./tsconfig.json",
       },
     },
-    rules: {
-      "@typescript-eslint/no-unsafe-assignment": "off",
-      "@typescript-eslint/no-unsafe-call": "off",
-      "@typescript-eslint/no-unsafe-member-access": "off",
-      "@typescript-eslint/no-unsafe-return": "off",
-      "@typescript-eslint/no-unsafe-argument": "off",
-      "node/no-unsupported-features/es-syntax": "off",
-    },
   },
 ];
diff --git a/examples/providers/eslint.config.mjs b/examples/providers/eslint.config.mjs
@@ -1,7 +1,9 @@
 import rootConfig from "../../eslint.config.mjs";
+import examplesConfig from "../eslint.config.mjs";
 
 export default [
   ...rootConfig,
+  ...examplesConfig,
   {
     files: ["**/*.{js,mjs,cjs,jsx,ts,tsx}"],
     languageOptions: {
@@ -10,13 +12,5 @@ export default [
         project: "./tsconfig.json",
       },
     },
-    rules: {
-      "@typescript-eslint/no-unsafe-assignment": "off",
-      "@typescript-eslint/no-unsafe-call": "off",
-      "@typescript-eslint/no-unsafe-member-access": "off",
-      "@typescript-eslint/no-unsafe-return": "off",
-      "@typescript-eslint/no-unsafe-argument": "off",
-      "node/no-unsupported-features/es-syntax": "off",
-    },
   },
 ];
diff --git a/examples/reflection/eslint.config.mjs b/examples/reflection/eslint.config.mjs
@@ -1,7 +1,9 @@
 import rootConfig from "../../eslint.config.mjs";
+import examplesConfig from "../eslint.config.mjs";
 
 export default [
   ...rootConfig,
+  ...examplesConfig,
   {
     files: ["**/*.{js,mjs,cjs,jsx,ts,tsx}"],
     languageOptions: {
@@ -10,13 +12,5 @@ export default [
         project: "./tsconfig.json",
       },
     },
-    rules: {
-      "@typescript-eslint/no-unsafe-assignment": "off",
-      "@typescript-eslint/no-unsafe-call": "off",
-      "@typescript-eslint/no-unsafe-member-access": "off",
-      "@typescript-eslint/no-unsafe-return": "off",
-      "@typescript-eslint/no-unsafe-argument": "off",
-      "node/no-unsupported-features/es-syntax": "off",
-    },
   },
 ];
diff --git a/examples/streaming/eslint.config.mjs b/examples/streaming/eslint.config.mjs
@@ -1,7 +1,9 @@
 import rootConfig from "../../eslint.config.mjs";
+import examplesConfig from "../eslint.config.mjs";
 
 export default [
   ...rootConfig,
+  ...examplesConfig,
   {
     files: ["**/*.{js,mjs,cjs,jsx,ts,tsx}"],
     languageOptions: {
@@ -10,13 +12,5 @@ export default [
         project: "./tsconfig.json",
       },
     },
-    rules: {
-      "@typescript-eslint/no-unsafe-assignment": "off",
-      "@typescript-eslint/no-unsafe-call": "off",
-      "@typescript-eslint/no-unsafe-member-access": "off",
-      "@typescript-eslint/no-unsafe-return": "off",
-      "@typescript-eslint/no-unsafe-argument": "off",
-      "node/no-unsupported-features/es-syntax": "off",
-    },
   },
 ];
diff --git a/examples/structuredOutputs/eslint.config.mjs b/examples/structuredOutputs/eslint.config.mjs
@@ -1,7 +1,9 @@
 import rootConfig from "../../eslint.config.mjs";
+import examplesConfig from "../eslint.config.mjs";
 
 export default [
   ...rootConfig,
+  ...examplesConfig,
   {
     files: ["**/*.{js,mjs,cjs,jsx,ts,tsx}"],
     languageOptions: {
@@ -10,13 +12,5 @@ export default [
         project: "./tsconfig.json",
       },
     },
-    rules: {
-      "@typescript-eslint/no-unsafe-assignment": "off",
-      "@typescript-eslint/no-unsafe-call": "off",
-      "@typescript-eslint/no-unsafe-member-access": "off",
-      "@typescript-eslint/no-unsafe-return": "off",
-      "@typescript-eslint/no-unsafe-argument": "off",
-      "node/no-unsupported-features/es-syntax": "off",
-    },
   },
 ];