Fix Clorinde eNA AtkSpd Not Applying #2327
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed C2 extending initial cast. C2 extension corrected to 6s.
Changed from 10f to 2f after in-game testing.
Syntax fix from previous PR?
- Add C2 DMG% buff when party member takes damage within field - Delay adding field by 1f after final Burst hit to avoid self-triggering
- Reapply remaining sanctum DoT ICD after burst
- Remove normal attacks resetting the boolean for whether skill had been reused - Rename boolean for skill reuse to make more sense - New function to remove field since it is used in several scenarios - Skill recast function now uses character skill tracking variable for skill duration
- Fixed burst casting skill if starting with skill off cooldown. - Set burst status to apply on cast to handle actions that can interrupt the burst being used before first hitmark. Will need to evaluate best way to cancel the first queued attack. - Removed old burstCast tracking variable.
- remove / 100 as well
- implement a1 - implement a4 - implement skill damage mitigation and self DoT - fix burst frames because no basis on sheet - fix burst punch/kick state for iframe semantics - move asc/cons checks into the functions - move c2 to its own event sub - rename remove field to pick up field
- two vars instead of array for flat dmg ratio
- fix c4 icd not being hitlag extended - adjust c4 heal message - c4 heal target should always be dehya
- fix slow punch hitmark - fix burst interaction with attack/skill during punches - add dash -> jump interaction during burst leading to kick - refactor jump canceling burst punches - min 6 punches idle, max 10 punches <C6, max 15 punches C6 applies now - remove burstFrames for constant - cannot cancel before first punch so simplified burst func
- doesn't really matter right now because burst punch/kick do not have hitlag
- fix frames - fix sac pickup timing to happen right before redeploy instead of on action start - remove unnecessary hitlag info for non-hitlag attacks - adjust c2 flag reset to be a bit more future-proof - fix skill damage DoT having icd (should have no icd)
Atk Speed did not apply accurately, adjusted animation length to account for attack speed. Hitmarks were moved up slightly (more accurate) to assist with BoL logic in configs.
The spinning hitbox of Mav's bike is emulated and iterates over enemies for a desired number of frames/hits. Currently only supports charge[hold=X] and charge[hits=X].
The spinning hitbox of Mav's bike is emulated and iterates over enemies for a desired number of frames/hits. Initial support for charge[hold/hits/final] and charge:X inputs.
Updating for golang lint errors. A lot of commented out code to implement later.
Initial Mavuika Charge Attack Logic The spinning hitbox of Mav's bike is emulated and iterates over enemies for a desired number of frames/hits. Supports using charge, charge[hold], charge[hits], charge[final]. No implementation of nightsoul checks or gadget handling.
imring
requested changes
Jan 30, 2025
| @@ -0,0 +1,60 @@ | |||
| package mavuika | |||
imring
added
kind: bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Atk Speed did not apply accurately, included adjusting animation length to account for attack speed.
Hitmarks were moved up slightly (should be more accurate) to assist with BoL logic in configs.