Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify yelan hitmarks. #2315

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

just1ce5
Copy link
Contributor

Addresses #2291 .

@soloxcx
Copy link
Contributor

soloxcx commented Jan 25, 2025

8 frames for Yelan N0 window sounds too high. Based on your recording it is perhaps more like 4 frames, similar to the other bow units recorded. However you need a 2nd character in the team to catch the 'grey-out' frame for when her jump starts. I was planning to tackle that issue so nbd if you don't, but I would re-record Yelan N0 timings according to the frame guide, also add the video to docs

@imring imring added kind: bug Existing code is bugged area: internal Related to artifacts/weapons/characters labels Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: internal Related to artifacts/weapons/characters kind: bug Existing code is bugged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants