Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove processes associated with 10x scRNA-seq #1326

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

romunov
Copy link
Contributor

@romunov romunov commented Mar 29, 2024

Processes removed are:

upload-sc-10x
cellranger-count
cellranger-mkref

  • Update CHANGELOG.rst for each commit separately:
    • Pay attention to write entries under the "Unreleased" section.
    • Mark all breaking changes as "BACKWARD INCOMPATIBLE:" and put them
      before non-breaking changes.
    • If a commit modifies a feature listed under "Unreleased" section,
      it might be sufficient to modify the existing CHANGELOG entry from previous
      commit(s).
  • Bump the process version:
    • MAJOR version (first number): Backward incompatible changes (changes
      that break the api/interface). Examples: renaming the input/output, adding
      mandatory input, removing input/output...
    • MINOR version (middle number): add functionality or changes in a
      backwards-compatible manner. Examples: add output field, add non-mandatory
      input parameter, use a different tool that produces same results...
    • PATCH version (last number): changes/bug fixes that do not affect
      the api/interface. Examples: typo fix, change/add warning messages...
  • All inputs are used in process.
  • All output fields have a value assigned to them.

@romunov romunov requested a review from jkokosar March 29, 2024 08:52
@jkokosar
Copy link
Member

Please rebase

Processes removed are:
``upload-sc-10x``
``cellranger-count``
``cellranger-mkref``
@romunov
Copy link
Contributor Author

romunov commented Mar 29, 2024

Done.

@jkokosar jkokosar merged commit 29eb73a into genialis:master Apr 2, 2024
3 checks passed
@romunov romunov deleted the remove/10x branch April 22, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants