Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use NULL_EXECUTOR in e2e tests #360

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Use NULL_EXECUTOR in e2e tests #360

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion .github/workflows/e2e.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,28 @@ jobs:
- name: Try the cluster
run: |
kubectl wait --for=condition=available --timeout=1200s -n default deployment/postgres
# Until postgres is fully restored, the services will fail
kubectl wait --for=condition=available --timeout=1200s -n default deployment/postgres
# Patch the channels manager to use the null executor
kubectl patch deployment channels-manager -n default --patch '{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we read the patch from a json file instead of inline?

"spec": {
"template": {
"spec": {
"containers": [
{
"name": "channels-manager",
"env": [
{
"name": "GENESIS_EXECUTOR_NULL",
"value": "1"
}
]
}
]
}
}
}
}'
# Perform a clean restart of all services after the database is online
kubectl rollout restart deployment asgi-server channels-manager listener background-task uploader
kubectl wait --for=condition=available --timeout=1200s --all deployments
Expand Down