[ch-dialog][ch-popover] Rename property name hidden to show
#469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include the following base tests files: - basic - parts - slots
add the following tests files: - drag - modal - position
Improve error log
Tests will be added on another PR
Update property and showcase file accordingly
✅ Deploy Preview for gx-chameleon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ncamera
requested changes
Jan 2, 2025
ncamera
changed the title
hidden to show in several components[ch-dialog][ch-popover] Rename property name hidden to show
ncamera
added
fix
…ender` - Add a `setTimeout` in order to force execution after browser paint. This fixes some E2E tests random fails, due to `this.#resizeLayer` being `undefined`.
ncamera
requested changes
Jan 3, 2025
For the button to be rendered, `showHeader` property should be `true`
Some tests are failing on `basic.e2e.ts` only on the server. Check what happens if `testDefaultProperty` is not run.
Although they are not required at the time of writting, setting this property to true ensures future compatibility, in the case the parts involved on these tests are dependent on the `show` property to be rendered.
ncamera
requested changes
Jan 7, 2025
These types of checks should be asserted on another test suite rather.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this PR:
Update the renamed
hiddenproperty in favor toshow, on the components that usech-popover:ch-combo-box-renderch-dropdownch-tooltipBreaking changes
hiddentoshowin the following components:ch-popoverch-dialogWhy this change?
The presence of the
hiddenproperty was causing issues on React, since "hidden" was being evaluated to true, regardless of the property value.