[ch-tooltip] If the mouse leaves the tooltip, only keep it visible if the focus is "focus-visible". Also improve rendering performance.
#465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…us is "focus-visible" Now, if the tooltip is shown by clicking on the actionElement, this fix will hide the tooltip when the mouse leaves the actionElement. Previously, the tooltip reamined visible until a new element in the UI was focused.
✅ Deploy Preview for gx-chameleon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ncamera
added
fix
ncamera
changed the title
[ch-tooltip] If the mouse leaves the tooltip, only keep it visible if the focus is "focus-visible". Also improve render performance.[ch-tooltip] If the mouse leaves the tooltip, only keep it visible if the focus is "focus-visible". Also improve rendering performance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes we propose in this PR:
Fix: If the mouse leaves the tooltip, only keep it visible if the focus is "focus-visible".
Now, if the tooltip is shown by clicking on the actionElement, this fix will hide the tooltip when the mouse leaves the
actionElement.Previously, the tooltip reamined visible until a new element in the UI was focused.
Perf: Don't render the
ch-popoverif the tooltip is not displayed.