-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use new support for prefixes in OBO format #119
Conversation
I think these changes fix a possibly unnoticed problem: IDs like Noting some problems:
|
@balhoff Originally, there was a sed command in there doing some filtering, do you mean something like that? |
@kltm we used https://github.com/geneontology/neo/blob/master/bin/fix-obo-uris.pl to hack in all the right expansions at the end, and this is supposed to now do it "right". But for TAIR:locus in particular I wonder if we can change the OBO generated from the GPI or GAF to not require a regex replacement that is needed by the transformation above. |
e.g. given this GAF line in the TAIR upstream src file:
have the ontobio code replace that |
@sierra-moxon I think the NEO build is getting the GAF straight from TAIR, so maybe that won't work. Unless we're okay with obtaining this from GO instead of TAIR. Line 434 in 5cb9a0d
Thank you though! |
ah ok - makes sense - I checked the go-site/metadata/datasets/tair.yaml but it didn't have a GPI so I assumed that somehow you were grabbing the created GPI, but this makes more sense! |
Superseded by #121. |
The latest ROBOT includes new OWL API support to make use of prefix definitions in OBO format. This will allow us to get rid of the perl regex hack. This should be a fix for geneontology/noctua#902. Also relates to #84 and #17.
These changes haven't been tested on a full build yet—may need to tweak prefix definitions. Also, the latest ROBOT is required for this to work.