add build for reacto.owl and go-lego-reacto.owl to stage_release #19288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 18, 2020
balhoff
requested changes
Apr 21, 2020
| wget -O ./reacto-tmp/biopax2go.jar --no-check-certificate https://github.com/geneontology/pathways2GO/releases/download/v0.1.0/biopax2go.jar | ||
| wget -O ./reacto-tmp/biopax.zip --no-check-certificate https://reactome.org/download/current/biopax.zip | ||
| unzip -o ./reacto-tmp/biopax.zip -d ./reacto-tmp/ | ||
| java -jar -Xmx8G ./reacto-tmp/biopax2go.jar -b ./reacto-tmp/Homo_sapiens.owl -reacto ./extensions/reacto -lego $(GO_LEGO).owl -chebi ./mirror/chebi.owl |
There was a problem hiding this comment.
Does -jar need to go just before the specified jar?
There was a problem hiding this comment.
It works as is, tested. I usually do it that way. I guess it might also work with the memory allocation argument right after java ?
There was a problem hiding this comment.
Interesting, I just always thought that the jar file was an argument to -jar.
There was a problem hiding this comment.
I think it is indeed an argument to -jar. I guess its clever enough to deal with both. I poked around a little and see examples of both patterns all over.
balhoff
approved these changes
Apr 21, 2020
|
I think this will be fine. Let's try this out. Worst case, we separate out the target to something separate to handle on the side. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses geneontology/pipeline#35