ImageCollection.containsBandNames: add argument to indicate the property that contains the band names
#425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fitoprincipe can you rebase your branch on current main I made a patch to avoid the service account issue generated from GEE latest update ? |
|
done |
12rambau
requested changes
Feb 3, 2025
| """Filter the :py:class:`ee.ImageCollection` by band names using the provided filter. | ||
|
|
||
| Args: | ||
| bandNames: List of band names to filter. | ||
| filter: Type of filter to apply. To keep images that contains all the specified bands use ``"ALL"``. To get the images including at least one of the specified band use ``"ANY"``. | ||
| bandNamesProperty: the name of the property that contains the band names. Defaults to 'system:band_name' because GEE stores them there. |
There was a problem hiding this comment.
Suggested change
| bandNamesProperty: the name of the property that contains the band names. Defaults to 'system:band_name' because GEE stores them there. | |
| bandNamesProperty: the name of the property that contains the band names. Defaults to GEE native default: 'system:band_name'. |
| """Filter the :py:class:`ee.ImageCollection` keeping only the images with all the provided bands. | ||
|
|
||
| Args: | ||
| bandNames: List of band names to filter. | ||
| bandNamesProperty: the name of the property that contains the band names. Defaults to 'system:band_name' because GEE stores them there. |
There was a problem hiding this comment.
Suggested change
| bandNamesProperty: the name of the property that contains the band names. Defaults to 'system:band_name' because GEE stores them there. | |
| bandNamesProperty: the name of the property that contains the band names. Defaults to GEE native default: 'system:band_name'. |
| """Filter the :py:class:`ee.ImageCollection` keeping only the images with any of the provided bands. | ||
|
|
||
| Args: | ||
| bandNames: List of band names to filter. | ||
| bandNamesProperty: the name of the property that contains the band names. Defaults to 'system:band_name' because GEE stores them there. |
There was a problem hiding this comment.
Suggested change
| bandNamesProperty: the name of the property that contains the band names. Defaults to 'system:band_name' because GEE stores them there. | |
| bandNamesProperty: the name of the property that contains the band names. Defaults to GEE native default: 'system:band_name'. |
12rambau
requested changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some image collections the images contain all bands but some are completely masked out. In this case, using the band names is useless and mosaicking will not fail, but the user could still want to use valid bands and avoid the masked ones.
There are 2 changes:
system:band_namesinstead of computing it on the fly and storing in a property with random name.