Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an icon and title to generic widget containers #2205

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

naschmitz
Copy link
Collaborator

@naschmitz naschmitz commented Jan 2, 2025

Overview:

  • Add an icon and title to the generic widget container.
  • Close and minimize buttons moved to the right-hand side of the widget container.
  • Title HTML element expands to fill the gap in the header.
  • Fixed other small bugs discovered while updating the unit tests.
  • Other widgets that use the generic container should set title and icon on the container.

TODOs:

  • Basemap selector (once submitted and rebased).

Screenshots:

Screenshot 2025-01-02 at 1 44 47 PM Screenshot 2025-01-02 at 1 48 17 PM Screenshot 2025-01-02 at 1 38 22 PM

Copy link
Collaborator

@sufyanAbbasi sufyanAbbasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid, thank you!

js/lit_widget.ts Outdated Show resolved Hide resolved
@naschmitz naschmitz merged commit 5f86b6c into gee-community:master Jan 3, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants