Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split basemap selector up into two select fields: provider and resource #2202

Merged
merged 6 commits into from
Jan 3, 2025
Merged

Split basemap selector up into two select fields: provider and resource #2202

merged 6 commits into from
Jan 3, 2025

Conversation

naschmitz
Copy link
Collaborator

Overview:

  • Split the basemap selector into two select fields: one for basemap provider, and another for the basemap resource.
  • The new UX is less overwhelming/confusing, as opposed to a flat list with all the basemaps listed.
  • Added Python and JS (Karma) unit tests.
  • Fixed other small bugs discovered while updating the unit tests.
  • I'm open to suggestions!

Try it out: https://colab.research.google.com/drive/1HMDb7UzAfxssg5uFmSWHegmMwovdVSvB?usp=sharing

Screenshots:
Screenshot 2024-12-30 at 3 36 50 PM Screenshot 2024-12-30 at 3 36 43 PM

Video recording: https://github.com/user-attachments/assets/18c05fb9-801e-4bad-bd71-48948f9868b4

@naschmitz naschmitz force-pushed the anywidget-basemap-update branch from aa3c7f3 to 422f181 Compare December 30, 2024 20:45
@naschmitz naschmitz changed the title Break basemap selector up into two select fields: provider and resource Split basemap selector up into two select fields: provider and resource Dec 30, 2024
giswqs
giswqs approved these changes Dec 31, 2024
View reviewed changes
Copy link
Member

@giswqs giswqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really nice! It works very well. Thank you for the amazon work.

sufyanAbbasi
sufyanAbbasi approved these changes Jan 3, 2025
View reviewed changes
Copy link
Collaborator

@sufyanAbbasi sufyanAbbasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incredible! Just a small code change suggestion, but otherwise, LGTM!

geemap/map_widgets.py Outdated Show resolved Hide resolved
@naschmitz naschmitz merged commit 13bdd69 into gee-community:master Jan 3, 2025
14 checks passed
@naschmitz naschmitz deleted the anywidget-basemap-update branch January 3, 2025 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sufyanAbbasi sufyanAbbasi sufyanAbbasi approved these changes

@giswqs giswqs giswqs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@naschmitz @giswqs @sufyanAbbasi