Address review comments.

gee-community · Nov 15, 2024 · 49e363b · 49e363b
1 parent 8c7d332
commit 49e363b
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 118 deletions.
diff --git a/geemap/core.py b/geemap/core.py
@@ -691,7 +691,8 @@ def _basemap_selector(self) -> Optional[map_widgets.BasemapSelector]:
         """Finds the basemap selector widget in the map controls.
 
         Returns:
-            Optional[map_widgets.BasemapSelector]: The basemap selector widget if found, else None.
+            Optional[map_widgets.BasemapSelector]: The basemap selector widget
+                if found, else None.
         """
         return self._find_widget_of_type(map_widgets.BasemapSelector)
 

diff --git a/js/basemap_selector.ts b/js/basemap_selector.ts
@@ -3,9 +3,9 @@ import { css, html, PropertyValues, TemplateResult } from "lit";
 import { property, query } from "lit/decorators.js";
 
 import { legacyStyles } from "./ipywidgets_styles";
+import { LitWidget } from "./lit_widget";
 import { materialStyles } from "./styles";
 import { loadFonts } from "./utils";
-import { LitWidget } from "./lit_widget";
 
 export interface BasemapSelectorModel {
     basemaps: string[];
@@ -64,7 +64,7 @@ export class BasemapSelector extends LitWidget<
                     class="legacy-button primary row-button close-button"
                     @click="${this.onCloseClicked}"
                 >
-                    <span class="close-icon material-symbols-outlined">&#xe5cd;</span>
+                    <span class="close-icon material-symbols-outlined">close</span>
                 </button>
             </div>`;
     }
@@ -76,7 +76,6 @@ export class BasemapSelector extends LitWidget<
         super.update(changedProperties);
     }
 
-
     private onChange(event: Event) {
         const target = event.target as HTMLInputElement;
         this.value = target.value;

diff --git a/js/ipywidgets_styles.ts b/js/ipywidgets_styles.ts
@@ -58,27 +58,27 @@ export const legacyStyles = css`
     }
 
     .legacy-select {
-        padding-right: 20px;
-        border: var(--jp-widgets-input-border-width) solid var(--jp-widgets-input-border-color);
+        -moz-appearance: none;
+        -webkit-appearance: none;
+        appearance: none;
+        background-color: var(--jp-widgets-input-background-color);
+        background-image: var(--jp-widgets-dropdown-arrow);
+        background-position: right center;
+        background-repeat: no-repeat;
+        background-size: 20px;
         border-radius: 0;
-        height: inherit;
-        flex: 1 1 var(--jp-widgets-inline-width-short);
-        min-width: 0;
-        box-sizing: border-box;
-        outline: none !important;
+        border: var(--jp-widgets-input-border-width) solid var(--jp-widgets-input-border-color);
         box-shadow: none;
-        background-color: var(--jp-widgets-input-background-color);
+        box-sizing: border-box;
         color: var(--jp-widgets-input-color);
+        flex: 1 1 var(--jp-widgets-inline-width-short);
         font-size: var(--jp-widgets-font-size);
-        vertical-align: top;
+        height: inherit;
+        min-width: 0;
+        outline: none !important;
         padding-left: calc(var(--jp-widgets-input-padding)* 2);
-        appearance: none;
-        -webkit-appearance: none;
-        -moz-appearance: none;
-        background-repeat: no-repeat;
-        background-size: 20px;
-        background-position: right center;
-        background-image: var(--jp-widgets-dropdown-arrow);
+        padding-right: 20px;
+        vertical-align: top;
 }
     }
 `;
diff --git a/js/layer_manager copy.ts b/js/layer_manager copy.ts