Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parallel make #266

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Fix parallel make #266

merged 1 commit into from
Nov 28, 2024

Conversation

marcadella
Copy link
Collaborator

No description provided.

@marcadella marcadella linked an issue Nov 28, 2024 that may be closed by this pull request
@marcadella marcadella requested a review from fabern November 28, 2024 12:39
@marcadella marcadella marked this pull request as ready for review November 28, 2024 12:39
@marcadella marcadella merged commit 2bb7315 into master Nov 28, 2024
7 checks passed
@marcadella marcadella deleted the 265-fix-parallel-make-errors branch November 28, 2024 12:58
@fabern
Copy link
Member

fabern commented Dec 2, 2024

@marcadella could you explain (briefly) what these changes did?
It looks like you could simplify the Make file by a lot.

@marcadella
Copy link
Collaborator Author

Firstly I removed Makevars.win because the compilation process is platform agnostic so there is no reason to duplicate the makefile specifically for Windows. Secondly, I removed half of the targets because they were not needed in the sense the the recipe for getting the .o also produces the .mod, so having a target for the .mod files was not needed. Thirdly I added a few targets which were missing and cause parallel make to fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix parallel make errors
2 participants