Homogenization 2.0 #254
Merged
Homogenization 2.0 #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update vignettes - Save full model outputs for Biomee (including site level) - Move BiomeE integration test - Change QMD -> QMD12 - Remove unused parameters for BiomeE (outputhourly, outputdaily, dist_frequency, do_reset_veg)
Closed
13 tasks
|
@fabern I haven't updated the documentation for P-model (point 4 in the old pull-request). I don't know p-model at all. I also completely re-written data_format.Rmd. To avoid back and forth, I propose that you just commit the changes you wish directly in this branch (253). |
|
Thanks @marcadella, most of my suggested changes to the order of the docs were already done by you in commit (499b2c2), I now made small, last adjustments in (63f29b3). This is ok to cover point 4. |
added 6 commits
November 18, 2024 14:22
…rection of psoil_sl leading to negative values.
- Fix post mortality metrics never set in annual_diagnostics - Fix annualfixedN never updated
Ag_l exploding causes Psyn, Gpp, plabl%c12, C_push, C_growth, dBSW, cc%DBH and oldcc%crownarea to be NaN Note that if this removes the segfault, we have not treated the root cause of the issue causing Ag_l to explode in the first place.
stineb
reviewed
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #253