Merge pull request #200 from pepaaran/master

Updated NEWS and cran-comments for CRAN submission
geco-bern · Feb 7, 2024 · 725a515 · 725a515
2 parents c5fb7a9 + 26373e1
commit 725a515
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 7 deletions.
diff --git a/CRAN-SUBMISSION b/CRAN-SUBMISSION
@@ -1,3 +1,3 @@
 Version: 4.4.1
-Date: 2023-11-13 18:38:30 UTC
-SHA: f22109ac135540b9afef33ca308aee1af9e22981
+Date: 2023-12-13 16:42:05 UTC
+SHA: 5f47128a04f01422a4f0f147f0e012043e1bc101
diff --git a/NEWS.md b/NEWS.md
@@ -1,6 +1,7 @@
 # rsofun v4.4.1
 
 * bugfix Fortran modules and derived types
+* compilation flags for different platforms
 
 # rsofun v4.4
 

diff --git a/configure b/configure
@@ -21,9 +21,9 @@ SFLAGS="`"${R_HOME}/bin/R" CMD config FCFLAGS`"
 # else or fail due to "unknown argument". In both cases the branch will
 # 
 # use this routine to create the header / start of the Makevars file
-if "$FC" --version 2>/dev/null | grep -q 'flang'; then
-echo "PKG_FCFLAGS =  $SFLAGS -fc-prototypes-external" > src/Makevars
-fi
+# if "$FC" --version 2>/dev/null | grep -q 'flang'; then
+# echo "PKG_FCFLAGS =  $SFLAGS -fc-prototypes-external" > src/Makevars
+# fi
 
 # Complete the Makevars file with known system agnostic settings
 cat src/Makevars.in >> src/Makevars
diff --git a/cran-comments.md b/cran-comments.md
@@ -1,8 +1,13 @@
 Dear CRAN team,
 
-This is the re-submission of the {rsofun} package. We have removed non-default lower bound specification in derived type, in order to fix the compilation issues that appeared in the Debian check.
+This is the re-submission of the {rsofun} package v4.4.1. 
 
-We were not able to reproduce the error shown by Prof. Ligges but have tried to solve the issue anyways, and our checks pass cleanly. If other issues arise or this one is still present, we would need to be provided with the configuration of the machine used to run the checks on CRAN's end. This way, we could reproduce the error and see if our changes get rid of it.
+In order to correct the outcome of the automatic CRAN checks, we have removed the 
+-fc-prototypes-external flag for flang compilers. Our local and GitHub checks
+pass, and we hope that the previous changes on the Fortran code alone correct
+the failure of our previous release.
+
+Thank you for your time and support.
 
 ---