tried to resolve check warnings

DESCRIPTION

@@ -15,10 +15,21 @@ Description: Derives time series of the cumulative water deficit (CWD), given ti
 Encoding: UTF-8
 URL: https://github.com/geco-bern/cwd
 BugReports: https://github.com/geco-bern/cwd/issues
-License: GPL-3
 Depends:
     R (>= 3.6)
 Imports:
-    dplyr
-ByteCompile: true
+    dplyr,
+    here,
+    lubridate,
+    readr
+Suggests:
+    rmarkdown,
+    knitr,
+    ggplot2,
+    patchwork,
+    extRemes
+License: AGPL-3
 RoxygenNote: 7.2.3
+Roxygen: list(markdown = TRUE)
+VignetteBuilder: knitr
+ByteCompile: true

NAMESPACE

@@ -3,4 +3,3 @@
 export(convert_et)
 export(cwd)
 export(simulate_snow)
-import(dplyr)

R/cwd.R

@@ -17,7 +17,7 @@
 #' during the remainder of the event is set to missing values. This is to avoid interpreting data
 #' after rain events but before full compensation of CWD. Defaults to 0.9.
 #'
-#' @import dplyr
+#' @importFrom dplyr
 #'
 #' @details A list of two data frames (tibbles). \code{inst} contains information about CWD "events".
 #' Each row corresonds to one event. An event is defined as a period of consecutive days where the
@@ -38,17 +38,16 @@ cwd <- function(df, varname_wbal, varname_date, thresh_terminate = 0.0, thresh_d
   # corresponds to mct2.R
 
   if (thresh_terminate > thresh_drop){
-    rlang::warn("Aborting. thresh_terminate must be smaller or equal thresh_drop. Setting it equal.")
+    warning("Aborting. thresh_terminate must be smaller or equal thresh_drop. Setting it equal.")
     thresh_terminate <- thresh_drop
   }
 
   inst <- tibble()
   idx <- 0
   iinst <- 1
 
-  df <- df %>%
-    ungroup() %>%
-    # dplyr::select(date, !!varname_wbal) %>%
+  df <- df |>
+    ungroup() |>
     mutate(iinst = NA, dday = NA, deficit = 0)
 
   # search all dates
@@ -111,7 +110,7 @@ cwd <- function(df, varname_wbal, varname_date, thresh_terminate = 0.0, thresh_d
 
       # record instance
       this_inst <- tibble( idx_start = idx, len = iidx_drop-idx, iinst = iinst, date_start=df[[varname_date]][idx], date_end = df[[varname_date]][iidx_drop-1], deficit = max_deficit )
-      inst <- inst %>% bind_rows(this_inst)
+      inst <- inst |> bind_rows(this_inst)
 
       # update
       iinst <- iinst + 1

R/simulate_snow.R

@@ -12,6 +12,8 @@
 #' @param varnam_prec A character string specifying the variable name for rain.
 #' @param varnam_snow A character string specifying the variable name for snow.
 #'
+#' @importFrom dplyr
+
 #' @details Returns a data frame with two added columns: (1) \code{liquid_to_soil}
 #' is the rain plus snow melt in mm d-1; (2) \code{snow_pool} is the snow mass
 #' in water equivalents (mm) for each day.

docs/pkgdown.yml

@@ -1,6 +1,7 @@
 pandoc: 3.1.1
 pkgdown: 2.0.7
 pkgdown_sha: ~
-articles: {}
-last_built: 2023-10-27T13:12Z
+articles:
+  cwd_example: cwd_example.html
+last_built: 2023-11-08T16:33Z
 

docs/sitemap.xml

@@ -6,16 +6,28 @@
   <url>
     <loc>/LICENSE-text.html</loc>
   </url>
+  <url>
+    <loc>/articles/cwd_example.html</loc>
+  </url>
+  <url>
+    <loc>/articles/index.html</loc>
+  </url>
   <url>
     <loc>/authors.html</loc>
   </url>
   <url>
     <loc>/index.html</loc>
   </url>
+  <url>
+    <loc>/reference/convert_et.html</loc>
+  </url>
   <url>
     <loc>/reference/cwd.html</loc>
   </url>
   <url>
     <loc>/reference/index.html</loc>
   </url>
+  <url>
+    <loc>/reference/simulate_snow.html</loc>
+  </url>
 </urlset>

vignettes/cwd_example.Rmd

@@ -1,8 +1,12 @@
 ---
 title: "Example"
 author: "Beni Stocker"
-date: "2023-11-08"
-output: html_document
+date: "`r Sys.Date()`"
+output: rmarkdown::html_vignette
+vignette: >
+  %\VignetteIndexEntry{map2tidy functionality}
+  %\VignetteEngine{knitr::rmarkdown}
+  %\VignetteEncoding{UTF-8}
 ---
 
 ```{r setup, include=FALSE}
@@ -128,8 +132,6 @@ vals <- out_cwd$inst %>%
 # Fit general extreme value distribution
 evd_gev <- extRemes::fevd(x = vals, type = "GEV", method = "MLE", units = "years")
 summary(evd_gev)
-
-plot(evd_gev)
 ```
 
 Get return levels for given return periods.