Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ruff Naming rule and fix most errors #591

Merged
merged 9 commits into from
Jan 30, 2025

fix tests

6e10f48
Select commit
Loading
Failed to load commit list.
Merged

Add ruff Naming rule and fix most errors #591

fix tests
6e10f48
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 30, 2025 in 1s

63.52% (+0.06%) compared to ecd5005

View this Pull Request on Codecov

63.52% (+0.06%) compared to ecd5005

Details

Codecov Report

Attention: Patch coverage is 86.20690% with 8 lines in your changes missing coverage. Please review.

Project coverage is 63.52%. Comparing base (ecd5005) to head (6e10f48).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/kfactory/factories/euler.py 70.58% 5 Missing ⚠️
src/kfactory/instance.py 86.66% 2 Missing ⚠️
src/kfactory/layout.py 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #591      +/-   ##
==========================================
+ Coverage   63.45%   63.52%   +0.06%     
==========================================
  Files          64       64              
  Lines        9566     9573       +7     
  Branches     1786     1785       -1     
==========================================
+ Hits         6070     6081      +11     
+ Misses       2945     2943       -2     
+ Partials      551      549       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.