Add more tests #571

MatthewMckee4 · 2025-01-25T12:59:20Z

Summary by Sourcery

Tests:

Added tests for the show command in the CLI.

sourcery-ai · 2025-01-25T12:59:24Z

Reviewer's Guide by Sourcery

This pull request adds tests for the kfactory CLI. It includes tests for the version callback and the show command. The tests cover cases with existing files, non-existent files, directories, and files with no permissions.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change	Details	Files
Added tests for the kfactory CLI.	Added a test for the version callback. Added a test for the show command. The show command test covers cases with existing files, non-existent files, directories, and files with no permissions.	`tests/cli/test_cli.py`

Tips and commands

Interacting with Sourcery

Trigger a new review: Comment @sourcery-ai review on the pull request.
Continue discussions: Reply directly to Sourcery's review comments.
Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it. You can also reply to a
review comment with @sourcery-ai issue to create an issue from it.
Generate a pull request title: Write @sourcery-ai anywhere in the pull
request title to generate a title at any time. You can also comment
@sourcery-ai title on the pull request to (re-)generate the title at any time.
Generate a pull request summary: Write @sourcery-ai summary anywhere in
the pull request body to generate a PR summary at any time exactly where you
want it. You can also comment @sourcery-ai summary on the pull request to
(re-)generate the summary at any time.
Generate reviewer's guide: Comment @sourcery-ai guide on the pull
request to (re-)generate the reviewer's guide at any time.
Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
pull request to resolve all Sourcery comments. Useful if you've already
addressed all the comments and don't want to see them anymore.
Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
request to dismiss all existing Sourcery reviews. Especially useful if you
want to start fresh with a new review - don't forget to comment
@sourcery-ai review to trigger a new review!
Generate a plan of action for an issue: Comment @sourcery-ai plan on
an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

Enable or disable review features such as the Sourcery-generated pull request
summary, the reviewer's guide, and others.
Change the review language.
Add, remove or edit custom review instructions.
Adjust other review settings.

Getting Help

Contact our support team for questions or feedback.
Visit our documentation for detailed guides and information.
Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

codecov · 2025-01-26T20:17:06Z

Codecov Report

Attention: Patch coverage is 66.20690% with 49 lines in your changes missing coverage. Please review.

Project coverage is 60.75%. Comparing base (5a2a063) to head (21ec21f).
Report is 34 commits behind head on main.

Files with missing lines	Patch %	Lines
src/kfactory/kcell.py	66.20%	37 Missing and 12 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #571      +/-   ##
==========================================
+ Coverage   59.30%   60.75%   +1.44%     
==========================================
  Files          49       49              
  Lines        9160     9185      +25     
  Branches     1739     1735       -4     
==========================================
+ Hits         5432     5580     +148     
+ Misses       3196     3085     -111     
+ Partials      532      520      -12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Fix locking logic

add some basic thread safety locks

sourcery-ai

We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.

sourcery-ai · 2025-01-27T14:39:31Z

tests/test_routing.py

-        for p1 in (True, False)
-        for p2 in (True, False)
-    ],
+    smart_bundle_routing_params,
 )
 def test_smart_routing(


issue (code-quality): Low code quality found in test_smart_routing - 7% (low-code-quality)

Explanation
The quality score for this function is below the quality threshold of 25%.
This score is a combination of the method length, cognitive complexity and working memory.

How can you solve this?

It might be worth refactoring this function to make it shorter and more readable.

Reduce the function length by extracting pieces of functionality out into
their own functions. This is the most important thing you can do - ideally a
function should be less than 10 lines.

Reduce nesting, perhaps by introducing guard clauses to return early.

Ensure that variables are tightly scoped, so that code using related concepts
sits together within the function rather than being scattered.

sourcery-ai · 2025-01-27T14:39:31Z

tests/test_settings.py

+    assert valid_data.key3 == [1, 2, 3]
+
+    with pytest.raises(ValidationError):
+        Info(key1=set([1, 2, 3]))


suggestion (code-quality): Unwrap a constant iterable constructor (unwrap-iterable-construction)

Suggested change

Info(key1=set([1, 2, 3]))

Info(key1={1, 2, 3})

sourcery-ai · 2025-01-27T14:39:31Z

tests/test_utilities.py

+    assert check_metadata_type({"key": "value"}) == {"key": "value"}
+
+    with pytest.raises(ValueError):
+        check_metadata_type(set([1, 2, 3]))  # type: ignore


suggestion (code-quality): Unwrap a constant iterable constructor (unwrap-iterable-construction)

Suggested change

check_metadata_type(set([1, 2, 3])) # type: ignore

check_metadata_type({1, 2, 3})

Add more tests

7e2c7fb

github-actions bot added the enhancement New feature or request label Jan 25, 2025

MatthewMckee4 added 3 commits January 26, 2025 19:53

Merge branch 'main' into add-tests

efb306c

try to remove tests dependency

ebce562

update github actions

0b69e97

github-actions bot added the github_actions Pull requests that update GitHub Actions code label Jan 26, 2025

update github actions

3ddbbbe

MatthewMckee4 and others added 21 commits January 26, 2025 20:31

fix routing

efda8d2

fix routing

be6617a

add some basic thread safety locks

50c1837

fix the KLayout lock

aa37f2e

change lock to reentrant lock

80a5d0f

fix xdist not working

96928cb

add more tests

fab69f0

Merge branch 'main' into add-tests

4d70419

try to fix merge error

1a68028

max cell name length in conf

f4cd6b1

fix taper duplicate name

7305aae

try to fix taper name issue

483c8e5

change back test_cells taper

c793240

fix locking

bf755e0

remove lock inside cached area

58e16d5

make taper fixture thread safe

7dc778b

fix virtual instance cell names

d4ec5fc

remove the taper dup in test_cells

7799135

Merge branch 'add-cache-lock' into fix-cell-name-errors

fe078c5

update test_data

9c98e2d

fix taper function

4fbcbd9

sebastian-goeldi and others added 5 commits January 27, 2025 14:06

remove cell name length increase in tests

ae05ec5

Merge pull request #579 from gdsfactory/fix-cell-name-errors

0654456

Fix locking logic

Merge branch 'add-tests' into add-cache-lock

f546a0a

Merge pull request #578 from gdsfactory/add-cache-lock

62267f7

add some basic thread safety locks

add more tests for cell decorator

21ec21f

MatthewMckee4 marked this pull request as ready for review January 27, 2025 14:38

MatthewMckee4 requested a review from sebastian-goeldi January 27, 2025 14:38

sourcery-ai bot reviewed Jan 27, 2025

View reviewed changes

sebastian-goeldi merged commit f3f62db into main Jan 27, 2025
16 checks passed

sebastian-goeldi deleted the add-tests branch January 27, 2025 14:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add more tests #571

Add more tests #571

MatthewMckee4 commented Jan 25, 2025 •

edited by sourcery-ai bot

Loading

sourcery-ai bot commented Jan 25, 2025 •

edited

Loading

Interacting with Sourcery

Customizing Your Experience

Getting Help

codecov bot commented Jan 26, 2025 •

edited

Loading

sourcery-ai bot left a comment

sourcery-ai bot Jan 27, 2025

sourcery-ai bot Jan 27, 2025

sourcery-ai bot Jan 27, 2025

	check_metadata_type(set([1, 2, 3])) # type: ignore
	check_metadata_type({1, 2, 3})

Add more tests #571

Add more tests #571

Conversation

MatthewMckee4 commented Jan 25, 2025 • edited by sourcery-ai bot Loading

Summary by Sourcery

sourcery-ai bot commented Jan 25, 2025 • edited Loading

Reviewer's Guide by Sourcery

File-Level Changes

Interacting with Sourcery

Customizing Your Experience

Getting Help

codecov bot commented Jan 26, 2025 • edited Loading

Codecov Report

sourcery-ai bot left a comment

Choose a reason for hiding this comment

sourcery-ai bot Jan 27, 2025

Choose a reason for hiding this comment

sourcery-ai bot Jan 27, 2025

Choose a reason for hiding this comment

sourcery-ai bot Jan 27, 2025

Choose a reason for hiding this comment

MatthewMckee4 commented Jan 25, 2025 •

edited by sourcery-ai bot

Loading

sourcery-ai bot commented Jan 25, 2025 •

edited

Loading

codecov bot commented Jan 26, 2025 •

edited

Loading