Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gdr 2224 #98

Merged
merged 30 commits into from
Dec 8, 2023
Merged

Gdr 2224 #98

merged 30 commits into from
Dec 8, 2023

Conversation

bczech
Copy link
Contributor

@bczech bczech commented Nov 15, 2023

Description

What changed?

Related JIRA issue: GDR-2224

Why was it changed?

To fix bug with displaying drug_moa and drug_moa2 for single-agent data and extending list of headers

Checklist for sustainable code base

  • I added tests for any code changed/added
  • I added documentation for any code changed/added
  • I made sure naming of any new functions is self-explanatory and consistent

Logistic checklist

  • Package version bumped
  • Changelog updated

Screenshots (optional)

@bczech bczech requested a review from a team as a code owner November 15, 2023 12:50
@bczech bczech requested review from marcin-kam and gladkia and removed request for a team November 15, 2023 12:50
Copy link
Contributor

@j-smola j-smola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you maybe add some test for get_optional_rowdata_fields()?

R/standardize_MAE.R Show resolved Hide resolved
tests/testthat/test-headers.R Outdated Show resolved Hide resolved
@bczech bczech requested a review from j-smola December 1, 2023 13:20
R/standardize_MAE.R Show resolved Hide resolved
R/utils.R Show resolved Hide resolved
R/manage_additional_metadata.R Show resolved Hide resolved
@bczech bczech merged commit 1e93b06 into master Dec 8, 2023
1 of 2 checks passed
@bczech bczech deleted the GDR-2224 branch December 8, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants