Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: utilize calc_sd function #160

Merged
merged 3 commits into from
Aug 20, 2024
Merged

refactor: utilize calc_sd function #160

merged 3 commits into from
Aug 20, 2024

Conversation

bczech
Copy link
Contributor

@bczech bczech commented Aug 19, 2024

Description

What changed?

Related JIRA issue: GDR-2558

Why was it changed?

To utilize similar function created in gDRutils

Checklist for sustainable code base

  • I added tests for any code changed/added
  • I added documentation for any code changed/added
  • I made sure naming of any new functions is self-explanatory and consistent

Logistic checklist

  • Package version bumped
  • Changelog updated

Screenshots (optional)

@bczech bczech requested a review from a team as a code owner August 19, 2024 08:54
@bczech bczech requested review from marcin-kam and darsoo and removed request for a team August 19, 2024 08:54
j-smola
j-smola approved these changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@j-smola j-smola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe could you also update:

    gDRstyle (>= 1.3.2),
    gDRimport (>= 1.3.2),
    gDRtestData (>= 1.3.2),

R/average_SE.R Show resolved Hide resolved
@bczech bczech merged commit 3433ac7 into main Aug 20, 2024
3 of 4 checks passed
@bczech bczech deleted the GDR-2558.2 branch August 20, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-smola j-smola j-smola approved these changes

@darsoo darsoo darsoo approved these changes

@marcin-kam marcin-kam Awaiting requested review from marcin-kam marcin-kam is a code owner automatically assigned from gdrplatform/pr-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bczech @darsoo @j-smola