Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gdr 2316 #128

Merged
merged 8 commits into from
Dec 18, 2023
Merged

Gdr 2316 #128

merged 8 commits into from
Dec 18, 2023

Conversation

bczech
Copy link
Contributor

@bczech bczech commented Dec 15, 2023

Description

What changed?

Related JIRA issue: GDR-2316

Why was it changed?

Checklist for sustainable code base

  • I added tests for any code changed/added
  • I added documentation for any code changed/added
  • I made sure naming of any new functions is self-explanatory and consistent

Logistic checklist

  • Package version bumped
  • Changelog updated

Screenshots (optional)

@bczech bczech requested a review from a team as a code owner December 15, 2023 12:55
@bczech bczech requested review from j-smola and gladkia and removed request for a team December 15, 2023 12:55
@gladkia
Copy link
Contributor

gladkia commented Dec 15, 2023

Please bump version and update changelog.

j-smola
j-smola approved these changes Dec 18, 2023
View reviewed changes
R/map_df.R Show resolved Hide resolved
tests/testthat/test-map_df.R Show resolved Hide resolved
@bczech bczech merged commit af78d42 into master Dec 18, 2023
2 of 3 checks passed
@bczech bczech deleted the GDR-2316 branch December 18, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-smola j-smola j-smola approved these changes

@gladkia gladkia gladkia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bczech @gladkia @j-smola