fix: charge stateless gas on jump #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gballet
commented
Jan 6, 2025
Signed-off-by: Guillaume Ballet <[email protected]>
gballet
force-pushed
the
fix-jumpi-stateless-gas-charge
branch
from
d3c9d9c to
9b476e9
Compare
jsign
approved these changes
Jan 6, 2025
…ract Signed-off-by: Ignacio Hagopian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No check was made to see if the access witness was allocated when charging for an invalid jump.
I have changed it to execute the charge regardless. This is redundant with the interpreter's execution loop, but I think it's easier to read.