types: fix json field name for execution witness parent state root #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
jsign
commented
Nov 1, 2024
| ParentStateRoot common.Hash `json:"parentRoot"` | ||
| ParentStateRoot common.Hash `json:"parentStateRoot"` |
| parent := v.bc.GetHeaderByNumber(header.Number.Uint64() - 1) | ||
| parent := v.bc.GetBlockByHash(header.ParentHash) |
There was a problem hiding this comment.
We can't rely on canonical chain until the node is synced, so in general this is a safer option for all use cases (syncing, tests, block creation).
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
jsign
commented
Nov 1, 2024
| FIXTURES_TAG: "[email protected]4" | ||
| FIXTURES_TAG: "[email protected]8" |
There was a problem hiding this comment.
New fixtures since the parent state root JSON field was renamed.
I'll run whenever the release is cut.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the new parent state root JSON field name in the witness to match what we get from CL. Additionally, we don't rely on canonical chain numbering to refer to the parent, which doesn't work in syncing mode.