avoid BASIC_DATA branch edit for free in existent accounts #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ignacio Hagopian <[email protected]>
jsign
commented
Oct 17, 2024
| // Note that we do a write-event in CodeHash without distinguishing if the tx target account | ||
| // exists or not. Pre-7702, there's no situation in which an existing codeHash can be mutated, thus | ||
| // doing a write-event shouldn't cause an observable difference in gas usage. | ||
| // TODO(7702): re-check this in the spec and implementation to be sure is a correct solution after | ||
| // EIP-7702 is implemented. | ||
| aw.touchAddressAndChargeGas(targetAddr, zeroTreeIndex, utils.CodeHashLeafKey, true, nil) | ||
| aw.touchAddressAndChargeGas(targetAddr, zeroTreeIndex, utils.CodeHashLeafKey, false, nil) |
There was a problem hiding this comment.
Reverting this to the way it was pre-yesterday PR. (Still keeping the renaming since it was a useful change).
Comment on lines
399
to
+402
| st.evm.Accesses.TouchTxTarget(targetAddr.Bytes(), msg.Value.Sign() != 0) | ||
| if !st.state.Exist(*targetAddr) { | ||
| st.evm.Accesses.TouchCodeHash(targetAddr.Bytes(), true, nil, false) | ||
| } |
There was a problem hiding this comment.
Turns out that the logic I made yesterday reg CODEHASH being immutable (before 7702) was fine. But this free CODEHASH write we did before is also giving for free a BRANCH_EDIT unconditionally.
This means that for existing addresses, the unconditional free write-event on CODEHASH made writes in BASIC_DATA cheaper (since CODEHASH got that for free, which attempted to be a simplification but is wrong).
jsign
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing a problem I found when filling the test now, I'll explain in comments.
cc @tanishqjasoria