fix: CREATE-time PUSHn adds non-existent entries to witness #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gballet
commented
Feb 5, 2024
| @@ -484,7 +484,7 @@ func TestProcessVerkle(t *testing.T) { | |||
| txCost1 := params.TxGas | |||
| txCost2 := params.TxGas | |||
| contractCreationCost := intrinsicContractCreationGas + uint64(7700 /* creation */ +2939 /* execution costs */) | |||
| codeWithExtCodeCopyGas := intrinsicCodeWithExtCodeCopyGas + uint64(7000 /* creation */ +315944 /* execution costs */) | |||
| codeWithExtCodeCopyGas := intrinsicCodeWithExtCodeCopyGas + uint64(7000 /* creation */ +299744 /* execution costs */) | |||
There was a problem hiding this comment.
so I realized that I never worked out the actual cost breakdown, and this should be done. It's added to my GTD list for later 😁
jsign
approved these changes
Feb 5, 2024
gballet
added a commit
that referenced
this pull request
May 7, 2024
* fix: CREATE-time PUSHn adds non-existent entries to witness * this also affects CODECOPY * fix: add code returned by CREATE* to the witness * fix gas costs
gballet
added a commit
that referenced
this pull request
May 8, 2024
* fix: CREATE-time PUSHn adds non-existent entries to witness * this also affects CODECOPY * fix: add code returned by CREATE* to the witness * fix gas costs
gballet
added a commit
that referenced
this pull request
May 8, 2024
* fix: CREATE-time PUSHn adds non-existent entries to witness * this also affects CODECOPY * fix: add code returned by CREATE* to the witness * fix gas costs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PUSHnwas callingtouchCodeChunksRangeOnReadAndChargeGaswhether it was in contract deployment mode or not, in order to make sure that any pushdata overflowing into the next chunks are also added to the witness.The issue is that in the case of a contract deployment, the address that is used is that of the contract that is yet to be created. If, for whatever reason, the deployment code ends up being larger than the contract payload that is written to the state, more chunks will be added to the witness than needs to be. This also means that deployment code is more likely to run out of gas.
This fix simply checks that we are not in deployment mode before charging this cost.