only create one triedb in GenerateVerkleChain #300
Conversation
| var snaps *snapshot.Tree | ||
| for i := 0; i < n; i++ { | ||
| triedb := state.NewDatabaseWithConfig(db, nil) | ||
| triedb.EndVerkleTransition() |
There was a problem hiding this comment.
removing EndVerkleTransition from the loop is incorrect in case the status of ended is linked to the root - because then the status has to be marked for every subsequent block. Clearly not a good thing.
Note to self: also write the end and start block number, so that we can tell if a block is in an ended state. We need to pass the block number all over the place and that is complicated. A better approach, to investigate in a different PR, might consist in storing the ending status in the statedb proper, so that you can access is from e.g. OpenTrie without having to pass it the block number.
|
Revisiting this PR. it clearly doesn't work after the rebase over |
|
It's been merged via another branch, closing. |
No description provided.