Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplement the 2-stage conversion process #190

Draft
wants to merge 9 commits into
base: beverly-hills-head
Choose a base branch
from

Conversation

gballet
Copy link
Owner

@gballet gballet commented Mar 24, 2023

This is a new take on Martin's "dumpfile" conversion approach.

@gballet gballet force-pushed the verkle/convert-through-files-rewrite branch from 2914561 to c12b0f1 Compare March 29, 2023 15:28
@gballet gballet marked this pull request as ready for review March 29, 2023 15:29
@gballet gballet changed the title dump+sort reimpl Reimplement the 2-stage conversion process Mar 29, 2023
@gballet
Copy link
Owner Author

gballet commented Mar 29, 2023

First stage completed in ~5h21m, good for a first try.

@jsign jsign mentioned this pull request Mar 29, 2023
jsign and others added 2 commits March 30, 2023 14:43
* fix compilation error

Signed-off-by: Ignacio Hagopian <[email protected]>

* print root in hex

Signed-off-by: Ignacio Hagopian <[email protected]>

* verkle/stage2: print elapsed time

Signed-off-by: Ignacio Hagopian <[email protected]>

* formatting

Signed-off-by: Ignacio Hagopian <[email protected]>

* Remove note-to-self comments in Frenglish

---------

Signed-off-by: Ignacio Hagopian <[email protected]>
Co-authored-by: Guillaume Ballet <[email protected]>
@gballet gballet requested a review from holiman as a code owner April 13, 2023 18:55
@gballet gballet marked this pull request as draft May 7, 2024 11:45
@gballet gballet added the on-hold label May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants