Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ionic Ubuntu source install: rosdep instructions #568

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

scpeters
Copy link
Member

🎉 New feature

Add instructions for installing dependencies using rosdep.

Summary

Our packages have package.xml files now, so users can use rosdep to install dependencies. Add instructions for Ionic with a --skip-keys gz-cmake3 argument to handle workspaces with gz-tools2 if users have the ROS apt repositories instead of packages.osrfoundation.org

Test it

Follow the build-from-source instructions in a fresh container with ROS rolling repositories but not packages.osrfoundation.org

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Add instructions for installing dependencies using rosdep.

Signed-off-by: Steve Peters <[email protected]>
# gz-tools2 can build from source against both gz-cmake3 and gz-cmake4
# this workspace has only gz-cmake4
# the gz-tools2 package.xml only lists gz-cmake3, so use --skip-keys gz-cmake3
rosdep install -i --from-path . --skip-keys gz-cmake3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you checked if this works for the whole workspace? I don't think there are rosdep keys for ogre-next and DART.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll test it now...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it currently fails to resolve DART from the gz-physics package.xml and libogre-next-2.3-dev from the gz-rendering9 package.xml

I suppose we could skip those for now as well. I'll add comments and open issues in gz-physics and gz-rendering about how to name these dependencies in a way that both colcon and rosdep are happy with

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we already have a solution, but it requires more steps. https://github.com/osrf/osrf-rosdep

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just updated with the extra --skip-keys arguments and some explanation

I believe we already have a solution, but it requires more steps. https://github.com/osrf/osrf-rosdep

I'm testing on gLinux with the ROS repos but not packages.osrfoundation.org. In this specific case, osrf-rosdep would help with resolving DART to libdart-dev, so I can update the instructions to include it, but it wouldn't help with gz-cmake3 or libogre* in this case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Inbox
Development

Successfully merging this pull request may close these issues.

2 participants