-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ionic Ubuntu source install: rosdep instructions #568
base: master
Are you sure you want to change the base?
Conversation
Add instructions for installing dependencies using rosdep. Signed-off-by: Steve Peters <[email protected]>
ionic/install_ubuntu_src.md
Outdated
# gz-tools2 can build from source against both gz-cmake3 and gz-cmake4 | ||
# this workspace has only gz-cmake4 | ||
# the gz-tools2 package.xml only lists gz-cmake3, so use --skip-keys gz-cmake3 | ||
rosdep install -i --from-path . --skip-keys gz-cmake3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you checked if this works for the whole workspace? I don't think there are rosdep keys for ogre-next
and DART
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll test it now...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it currently fails to resolve DART
from the gz-physics package.xml and libogre-next-2.3-dev
from the gz-rendering9 package.xml
I suppose we could skip those for now as well. I'll add comments and open issues in gz-physics and gz-rendering about how to name these dependencies in a way that both colcon
and rosdep
are happy with
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we already have a solution, but it requires more steps. https://github.com/osrf/osrf-rosdep
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just updated with the extra --skip-keys
arguments and some explanation
I believe we already have a solution, but it requires more steps. https://github.com/osrf/osrf-rosdep
I'm testing on gLinux
with the ROS repos but not packages.osrfoundation.org. In this specific case, osrf-rosdep
would help with resolving DART to libdart-dev, so I can update the instructions to include it, but it wouldn't help with gz-cmake3
or libogre*
in this case
Signed-off-by: Steve Peters <[email protected]>
🎉 New feature
Add instructions for installing dependencies using rosdep.
Summary
Our packages have
package.xml
files now, so users can userosdep
to install dependencies. Add instructions for Ionic with a--skip-keys gz-cmake3
argument to handle workspaces withgz-tools2
if users have the ROS apt repositories instead of packages.osrfoundation.orgTest it
Follow the build-from-source instructions in a fresh container with ROS rolling repositories but not packages.osrfoundation.org
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.