Update running-gatewayd.md to handle Docker host connection for different setups #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sinadarbouy is attempting to deploy a commit to the GatewayD Labs Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mostafa
reviewed
May 31, 2024
There was a problem hiding this comment.
@sinadarbouy Thanks for your contribution!
I made a comment to simplify your change.
Consider running bash generate_last_modified_data.sh and committing the update timestamps in all files.
mostafa
reviewed
May 31, 2024
- Added instructions for setting DOCKER_HOST variable to host.docker.internal when using Docker Desktop. - Removed unnecessary defining Signed-off-by: sinadarbouy <[email protected]>
sinadarbouy
force-pushed
the
fix/fix-docker-host-variable-docker-desktop
branch
from
362c5df to
9009045
Compare
mostafa
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the issue of setting the Docker host variable when running on Docker Desktop. Due to the networking implementation in Docker Desktop, the
docker0bridge interface is not present on the host. Instead, we can use the DNS name (https://docs.docker.com/desktop/networking/#use-cases-and-workarounds)Changes Made
DOCKER_HOSTvariable tohost.docker.internalwhen using Docker Desktop.Context
When running on Docker Desktop, the absence of the docker0 bridge interface on the host can lead to confusion regarding how to correctly set up the Docker host variable.