Fix comment cloning promise so it only resolves when done #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se as possible & auto-format
Works by replacing github.com with www.github.com
This was referenced Mar 5, 2023
|
@djahandarie I have just merged in my PR that updates quite a bit of the main code file and also brings the google chrome extension manifest version to 3. If you would still like, please rebase and make the changes against the new codebase. Much appreciated |
|
I believe this has been alleviated with the refactoring and another PR that I am about to open. If it continues, I will take another stab at it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This is a stacked PR on top of #188 ~ #191)
Currently the "Go to original repo's issue list after cloning" functionality doesn't quite work in conjunction with "Copy comments when cloning issue", because the promise in
cloneOldIssueCommentsresolved too early and the redirect would cause remaining requests to get aborted.This PR fixes it so the comment cloning promise only resolves when the final comment XHR request finishes.