Optionally configure nodes to use NTP instead of systemd-timesyncd #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Niclas Schad <[email protected]>
Signed-off-by: Niclas Schad <[email protected]>
Signed-off-by: Niclas Schad <[email protected]>
…onfig" Signed-off-by: Niclas Schad <[email protected]>
…imesyncd and ntp Signed-off-by: Niclas Schad <[email protected]>
Signed-off-by: Niclas Schad <[email protected]>
Signed-off-by: Niclas Schad <[email protected]>
Signed-off-by: Niclas Schad <[email protected]>
Signed-off-by: Niclas Schad <[email protected]>
Signed-off-by: Niclas Schad <[email protected]>
Signed-off-by: Niclas Schad <[email protected]>
Signed-off-by: Niclas Schad <[email protected]>
Signed-off-by: Niclas Schad <[email protected]>
Signed-off-by: Niclas Schad <[email protected]>
Signed-off-by: Niclas Schad <[email protected]>
gardener-robot
added
area/os
|
@nschad Thank you for your contribution. |
gardener-robot
added
needs/review
|
Thank you @nschad for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area os
/kind enhancement
/os ubuntu
What this PR does / why we need it:
We have added a new ExtensionConfig to this extension, enabling operators to configure an optional switch for nodes to use a more advanced NTP daemon instead of the default systemd-timesyncd. While systemd-timesyncd supports only SNTP, the advanced NTP daemon offers enhanced features, such as cross-checking multiple time servers, which significantly improves time synchronization accuracy in scenarios where systemd-timesyncd might fall short.
The necessary configuration files for this feature are deployed during the "reconcile" phase rather than the "provision" phase. This decision helps minimize the data in the "provision" phase, avoiding potential issues with user data size limits imposed by various providers.
The controller deploys a small script, backed by systemd unit of type
oneshotthat installs (if necessary) the requested ntp client.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
In-case the systemd-unit fails then that error is AFAIK not reported back to gardener. In our tests it looked like the gardener-node-agent does not check the service for status.
Release note: