-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introducing new go module for API, remove g/g dependency #988
base: master
Are you sure you want to change the base?
Conversation
@unmarshall You need rebase this pull request with latest master branch. Please check. |
…and fixed skaffold, no need to have gcloud auth login
… for helm, corrected helm charts, created client as go module
…le target to clean generated resources for chart
… pki resources and fixed skaffold debug profile config
/retest |
@unmarshall: The following tests failed, say
Full PR test history. Your PR dashboard. Command help for this repository. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
How to categorize this PR?
/area control-plane
/area dev-productivity
/area open-source
/kind technical-debt
/kind enhancement
/kind api-change
What this PR does / why we need it:
PR introduces the following changes:
Etcd
andEtcdCopyBackupTask
CRs which provide any consumers typed clients to interact with these resources.ImageVector
code (underinternal/utils/imagevector
as a stop-gap measure till g/g deliberates on moving this functionality into its own go-module).PodLabels
as part ofEtcdCopyBackupsTaskSpec
- currently networking specific labels were hard coded which were very specific to gardener usage. Now the consumers can pass in any additional labels that needs to be applied to the Pods that are started as part of a Job that gets created.internal/controller/secret
internal/utils/kubernetes
internal/utils/miscellaneous.go
gcloud auth login
even though we were starting the kind cluster with local docker registry. This PR adds a small fix to skaffold.yaml which removes the need to rungcloud auth login
.hack/prepare-helm-charts.sh
script.hack/prepare-heml-charts.sh
andhack/openssl-util.sh
scripts..Files.Get
andb64enc
functions to bring in the PKI artifacts.etcd-druid/config
directory as this was not maintained. Moved outconfig/samples
toetcd-druid/samples
git_tags
to.ci/pipeline_definition
allowing proper tagging for go modules when release is done.Note
You will notice that the API directory structure introduces
api/core/v1alpha1
. This is deliberately done. This allows introduction of operator config in subsequent PR (underapi/config/v1alpha1
directory) which will completely replace the existing CLI args. The code generation scripts will be used to generate defaulting functions for the operator config.Note
go.work and go.work.sum are added to the repo. This will make developing across different go modules easier especially when there are dependencies amongst them. In addition, if you remove these files then
make sast
will stop working (see securego/gosec#1100 (comment) for mode details).Which issue(s) this PR fixes:
Fixes #972 #968 #969 and partially resolves 940
Special notes for your reviewer:
Release note: