Store output files in the given directory #406
Conversation
|
@ChunYen-Chen Please solve the conflicts. |
Conflicts: include/Global.h src/Main/Main.cpp
| @@ -77,6 +77,7 @@ int OPT__UM_IC_FLOAT8; | |||
| double COM_CEN_X, COM_CEN_Y, COM_CEN_Z, COM_MAX_R, COM_MIN_RHO, COM_TOLERR_R; | |||
| int COM_MAX_ITER; | |||
| double ANGMOM_ORIGIN_X, ANGMOM_ORIGIN_Y, ANGMOM_ORIGIN_Z; | |||
| char DUMP_DIR[MAX_STRING]; | |||
There was a problem hiding this comment.
Rename it to OUTPUT_DIR to match the names of other output-related variables
| @@ -59,7 +59,8 @@ void CUAPI_DiagnoseDevice() | |||
|
|
|||
|
|
|||
| // record the device properties | |||
| const char FileName[] = "Record__Note"; | |||
| char FileName[MAX_STRING]; | |||
| sprintf( FileName, "%s/Record__Note", DUMP_DIR ); | |||
There was a problem hiding this comment.
It triggers the following warning message. One simple solution could be reducing the size of DUMP_DIR (e.g., MAX_STRING-100), although this approach isn’t very elegant. Do you have a better solution?
GPU_API/CUAPI_DiagnoseDevice.cu:63:19: warning: ‘/Record__Note’ directive writing 13 bytes into a region of size between 1 and 512 [-Wformat-overflow=]
63 | sprintf( FileName, "%s/Record__Note", DUMP_DIR );
There was a problem hiding this comment.
It would be great if Aux_CheckFolderExist() could also validate whether users have write permissions for the target folder (e.g., the folder might exist but not be owned by the user).
src/Output/Output_L1Error.cpp
Outdated
There was a problem hiding this comment.
Update the line sprintf( FileName[NCOMP_FLUID+v], "%s_Passive%02d_%06d", Prefix, v, DumpID ); as well.
doc/wiki/Runtime-Parameters-related/Runtime-Parameters:-Outputs.md
Outdated
Show resolved
Hide resolved
|
@ChunYen-Chen Additionally, should we also store |
Co-authored-by: Hsi-Yu Schive <[email protected]>
Resolve #395.