-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store output files in the given directory #406
Store output files in the given directory #406
Conversation
@ChunYen-Chen Please solve the conflicts. |
Conflicts: include/Global.h src/Main/Main.cpp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ChunYen-Chen Good job! I've added some minor comments.
doc/wiki/Runtime-Parameters-related/Runtime-Parameters:-Outputs.md
Outdated
Show resolved
Hide resolved
@ChunYen-Chen Additionally, should we also store |
Co-authored-by: Hsi-Yu Schive <[email protected]>
…/gamer-fork into save_in_other_place Conflicts: src/Auxiliary/Aux_Check_Parameter.cpp
…/gamer-fork into save_in_other_place
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hyschive Thanks for the review. I have updated the PR.
Please update it to match the latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ChunYen-Chen Thanks for the contribution! I have some comments to be addressed before merging.
doc/wiki/Runtime-Parameters-related/Runtime-Parameters:-Outputs.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Hsi-Yu Schive <[email protected]>
…/gamer-fork into save_in_other_place
Resolve #395.