Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store output files in the given directory #406

Merged
merged 28 commits into from
Jan 17, 2025

Conversation

ChunYen-Chen
Copy link
Collaborator

Resolve #395.

@hyschive hyschive self-assigned this Jan 15, 2025
@hyschive hyschive added enhancement output Data output and log labels Jan 15, 2025
@hyschive
Copy link
Contributor

@ChunYen-Chen Please solve the conflicts.

Copy link
Contributor

@hyschive hyschive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChunYen-Chen Good job! I've added some minor comments.

src/Main/Main.cpp Outdated Show resolved Hide resolved
src/Auxiliary/Aux_CheckFileExist.cpp Outdated Show resolved Hide resolved
src/Auxiliary/Aux_CheckFileExist.cpp Outdated Show resolved Hide resolved
src/Auxiliary/Aux_CheckFileExist.cpp Outdated Show resolved Hide resolved
src/GPU_API/CUAPI_DiagnoseDevice.cu Outdated Show resolved Hide resolved
src/Auxiliary/Aux_Check_Parameter.cpp Outdated Show resolved Hide resolved
src/Auxiliary/Aux_CheckFileExist.cpp Show resolved Hide resolved
src/Output/Output_DumpData.cpp Outdated Show resolved Hide resolved
src/Output/Output_L1Error.cpp Outdated Show resolved Hide resolved
@hyschive
Copy link
Contributor

@ChunYen-Chen Additionally, should we also store OUTPUT_DIR in HDF5 snapshots and check it in Init_ByRestart_HDF5.cpp?

Copy link
Collaborator Author

@ChunYen-Chen ChunYen-Chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hyschive Thanks for the review. I have updated the PR.

src/Auxiliary/Aux_CheckFileExist.cpp Show resolved Hide resolved
src/GPU_API/CUAPI_DiagnoseDevice.cu Outdated Show resolved Hide resolved
@hyschive
Copy link
Contributor

Please update it to match the latest main.

Copy link
Contributor

@hyschive hyschive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChunYen-Chen Thanks for the contribution! I have some comments to be addressed before merging.

src/Auxiliary/Aux_Check_Parameter.cpp Outdated Show resolved Hide resolved
src/Auxiliary/Aux_Check_Parameter.cpp Outdated Show resolved Hide resolved
src/Auxiliary/Aux_Check_Parameter.cpp Outdated Show resolved Hide resolved
src/Auxiliary/Aux_CheckFileExist.cpp Outdated Show resolved Hide resolved
src/Auxiliary/Aux_CheckFileExist.cpp Outdated Show resolved Hide resolved
src/Auxiliary/Aux_CheckFileExist.cpp Outdated Show resolved Hide resolved
@hyschive hyschive merged commit 5b9e30c into gamer-project:main Jan 17, 2025
@ChunYen-Chen ChunYen-Chen deleted the save_in_other_place branch January 22, 2025 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement output Data output and log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Define a different directory to store output Data* files when running the simulation
2 participants