feat (tabs): added option to make height equal throughout the tab's contents #2926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prconcepcion
changed the title
prconcepcion
changed the title
🤖 Pull request artifacts
|
|
Size Change: +1.92 kB (0%) Total Size: 1.98 MB
ℹ️ View Unchanged
|
bfintal
requested changes
Oct 26, 2023
There was a problem hiding this comment.
A few comments:
-
When you already have a tabs block and you update, in the backend, your tab content will resize smaller when changing tabs (it should not)
-
When you already have a tabs block and you update, the tabs became not equal height. The option should be pre-enabled for existing tabs. (although if I hit preview, the frontend still showed equal height)
-
I couldn't find the option to change the height, please move it to the main tabs block and not the tab content block.
-
Change the option label to "Equal tab height"
|
@bfintal i temporarily changed the stackable version |
bfintal
requested changes
Oct 27, 2023
src/block/tabs/style.js
Outdated
| @@ -43,6 +43,18 @@ const Styles = props => { | |||
| format="%spx" | |||
| responsive="all" | |||
| /> | |||
| <BlockCss | |||
| { ...propsToPass } | |||
| selector=".%s .stk-block-tab-content > .stk-block-content > .stk-block-column[hidden]" | |||
There was a problem hiding this comment.
We cannot have > signs in the selector for the save render. WP has a bug that it will throw an error in multisite.
Please change the implementation so we do not have > in the selector. Note that this is okay for edit
src/block/tabs/deprecated.js
Outdated
Comment on lines
11
to
15
| return { | ||
| ...attributes, | ||
| equalTabHeight: true, | ||
| } | ||
| }, |
There was a problem hiding this comment.
As discussed, you will need to include the things in the older migrate method for 3.11.9:
let newAttributes = { ...attributes }
newAttributes = deprecateContainerBackgroundColorOpacity.migrate( newAttributes )
newAttributes = deprecateBlockBackgroundColorOpacity.migrate( newAttributes )
return newAttributesThis is because deprecation only stops when it encounters the first satisfied deprecation, so all users with an old tabs block will never get migration to the new combined opacity and color.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2844