[24.2] Set content-type to text/plain if dataset not safe #19563
+184
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvdbeek
commented
Feb 7, 2025
| </script> | ||
| <template> | ||
| <div class="h-100"> |
There was a problem hiding this comment.
Not sure why that's needed, without the h-100 the default welcome page gets squished into a small-ish box
mvdbeek
force-pushed
the
replace_sanitize_html
branch
from
c2e8ead to
18851a9
Compare
martenson
approved these changes
Feb 7, 2025
mvdbeek
force-pushed
the
replace_sanitize_html
branch
from
df23ee8 to
c0e4eb4
Compare
We only care about XSS in the content of the webapp, and for that it is sufficient to set the content-type to text/plain.
Seems required for center page.
mvdbeek
force-pushed
the
replace_sanitize_html
branch
from
c0e4eb4 to
49c6d6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only care about XSS in the context of the webapp, and for that it is sufficient to set the content-type to text/plain.
We might be passing large secondary files through this which has performance implications.
Also adds a sanitization message and a loading indicator for the iframe content if we're hitting a preview route.
The allow list link is only shown for admins.
How to test the changes?
(Select all options that apply)
Create an HTML file with a tool that creates HTML files (multiqc, fastqc etc). Click on the eye icon and see that the file is displayed as text if it is not on the allow list. Hardcode content-type on line 647 to
text/htmlto see that now it is rendered as html. Hardcode it back totext/planand see it displayed as text.License