[24.0] Fix extracting workflows from purged and deleted histories

[mvdbeek]

I'm pretty sure this used to work. Anyway, this also fixes extracting workflows from histories where some / all datasets are deleted. No tests -- we should port this over to use the API.

How to test the changes?

(Select all options that apply)

• I've included appropriate automated tests.
• This is a refactoring of components with existing test coverage.
• Instructions for manual testing are as follows:
  1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

• I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

[bernt-matthias]

Wonderful.

We would need to backport #18113 to make this useful on 24.0, or?

[mvdbeek]

You could navigate to workflow/build_from_current_history?history_id=<history_id>, but else yes.

[bernt-matthias]

You could navigate to workflow/build_from_current_history?history_id=<history_id>, but else yes.

I would be happy with this :) .. And upgrading to 24.1 anyway soon.

[bernt-matthias]

Does this mean that all steps (purged,deleted,active) from the history will be included in the workflow build form? Will all of them be pre-selected for inclusion?

[mvdbeek]

yes

[bernt-matthias]

Would it be easy to have only active ones pre-selected?

[mvdbeek]

It's probably doable, but of course all your purged history items are deleted

[bernt-matthias]

It's probably doable, but of course all your purged history items are deleted

Hah. Forgot about my usecase and thought about the "normal" usecase of a user who had made some errors and deleted those steps. I guess it this case it would be more "reasonable" to pre-select only active datasets (and closer to the current behavior).

Ideally one probably would like to have a behavior like for importing hostories where one can choose if only the active ones or also the deleted/purged ones should be included.

[mvdbeek]

Ideally one probably would like to have a behavior like for importing hostories where one can choose if only the active ones or also the deleted/purged ones should be included.

That makes sense, but probably not for something that is still in mako.

This is straightforward and should also convey all of the necessary information: