[24.0] Fix test_storage_show API test

[nsoranzo]

Pass hda id instead of dataset id to dataset_storage_info().

Fix the following traceback:

    def test_storage_show(self, history_id):
        hda = self.dataset_populator.new_dataset(history_id, wait=True)
        hda_details = self.dataset_populator.get_history_dataset_details(history_id, dataset=hda)
        dataset_id = hda_details["dataset_id"]
>       storage_info_dict = self.dataset_populator.dataset_storage_info(dataset_id)

...

        if http_error_msg:
>           raise HTTPError(http_error_msg, response=self)
E           requests.exceptions.HTTPError: 404 Client Error: Not Found for url: http://127.0.0.1:9129/api/datasets/9a58064fb2c43d99/storage

http_error_msg = ('404 Client Error: Not Found for url: '
 'http://127.0.0.1:9129/api/datasets/9a58064fb2c43d99/storage')
reason     = 'Not Found'
self       = <Response [404]>

Broken since the test was introduced in commit c5bf63b .

Started failing after #19506 , but probably just because of database ids changing.

How to test the changes?

(Select all options that apply)

• I've included appropriate automated tests.
• This is a refactoring of components with existing test coverage.
• Instructions for manual testing are as follows:
  1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

• I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

[davelopez]

Thanks for noticing! Also thanks for removing the unused requires_new_history leftover 👍