Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.2] Fix minor typo in event name in collection creator #19498

Closed

Conversation

ahmedhamidawan
Copy link
Member

Parent component CollectionCreator expects the emit name to be click-upload and we had it as clicked-upload here.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

Parent component `CollectionCreator` expects the emit name to be `click-upload` and we had it as `clicked-upload` here.
@github-actions github-actions bot added this to the 25.0 milestone Jan 30, 2025
@ahmedhamidawan ahmedhamidawan deleted the rename_no_collection_items_message_emit branch January 31, 2025 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant